REMOVE_DIST_ARRAYS_FROM_IO: STMT_STR while replacing

CMakeLists.txt

@@ -238,14 +238,14 @@ set(CFG src/CFGraph/IR.cpp
         src/CFGraph/live_variable_analysis.h
         src/CFGraph/private_variables_analysis.cpp
         src/CFGraph/private_variables_analysis.h
-        src/CFGraph/IR_SSAForm.cpp
+        )
-        src/CFGraph/IR_SSAForm.h)
         
 set(DATA_FLOW
         src/CFGraph/DataFlow/data_flow.h
         src/CFGraph/DataFlow/data_flow_impl.h
         src/CFGraph/DataFlow/backward_data_flow.h
-        src/CFGraph/DataFlow/backward_data_flow_impl.h)
+        src/CFGraph/DataFlow/backward_data_flow_impl.h
+        )
 
 set(CREATE_INTER_T  src/CreateInterTree/CreateInterTree.cpp
         src/CreateInterTree/CreateInterTree.h)
@@ -321,9 +321,7 @@ set(GR_LOOP src/GraphLoop/graph_loops_base.cpp
 set(LOOP_ANALYZER  src/LoopAnalyzer/allocations_prepoc.cpp
         src/LoopAnalyzer/dep_analyzer.cpp        
         src/LoopAnalyzer/loop_analyzer.cpp
-        src/LoopAnalyzer/loop_analyzer.h
+        src/LoopAnalyzer/loop_analyzer.h)
-        src/LoopAnalyzer/implicit_loops_analyzer.cpp
-        src/LoopAnalyzer/implicit_loops_analyzer.h)
 
 set(MAIN src/Sapfor.cpp
         src/Sapfor.h

src/CFGraph/CFGraph.cpp

@@ -50,30 +50,12 @@ BBlock::BasicBlock(const BBlock& copyFrom)
     prev = copyFrom.prev;
 }
 
-void BBlock::addInstruction(IR_Block* item, bool pushFront)
+void BBlock::addInstruction(IR_Block* item)
 {
-    if (pushFront)
-        instructions.insert(instructions.begin(), item);
-    else
     instructions.push_back(item);
     item->setBasicBlock(this);
 }
 
-void BBlock::addInstructionBefore(IR_Block* item, Instruction* before)
-{
-    checkNull(before, convertFileName(__FILE__).c_str(), __LINE__);
-    checkNull(item, convertFileName(__FILE__).c_str(), __LINE__);
-
-    for (auto it = instructions.begin(); it != instructions.end(); ++it) {
-        if ((*it)->getInstruction() == before) {
-            instructions.insert(it, item);
-            item->setBasicBlock(this);
-            return;
-        }
-    }
-    printInternalError(convertFileName(__FILE__).c_str(), __LINE__);
-}
-
 int BBlock::removePrev(BBlock* removed)
 {
     auto it = std::remove(prev.begin(), prev.end(), removed);
@@ -530,7 +512,7 @@ static int buildReachingDefs(const vector<BBlock*>& CFG, const FuncInfo* currF,
     return iter;
 }
 
-//Kosaraju-Sharir algorithm
+//Kosaraju<EFBFBD>Sharir algorithm
 static vector<int> getStronglyConnectedComps(vector<vector<int>>& g) {
     // 1. For each vertex u of the graph, mark u as unvisited. Let l be empty.
     auto size = g.size();
@@ -1180,9 +1162,6 @@ map<FuncInfo*, vector<BBlock*>> buildCFG(const map<string, CommonBlock*>& common
     if (SgFile::switchToFile(oldFile) == -1)
         printInternalError(convertFileName(__FILE__).c_str(), __LINE__);
 
-    for (auto& [func, blocks] : result)
-        removedUnreachableBlocks(blocks);
-
     return result;
 }
 
@@ -1258,48 +1237,3 @@ map<FuncInfo*, vector<SAPFOR::BasicBlock*>>
 
     return buildCFG(commonBlocks, fileFuncInfoMap, settings);
 }
-
-
-void removedUnreachableBlocks(vector<SAPFOR::BasicBlock*>& blocks)
-{
-    set<SAPFOR::BasicBlock*> reachable;
-
-    for (auto& b : blocks)
-        if (b->getInstructions().front()->isHeader() ||
-            b->getInstructions().front()->getInstruction()->getOperation() == SAPFOR::CFG_OP::ENTRY)
-            reachable.insert(b);
-
-    set<SAPFOR::BasicBlock*> worklist = reachable;
-    while (worklist.size() != 0)
-    {
-        set<SAPFOR::BasicBlock*> to_insert;
-
-        for (auto& b : worklist)
-            for (auto& next : b->getNext())
-                if (reachable.insert(next).second)
-                    to_insert.insert(next);
-
-        worklist = to_insert;
-    }
-
-    auto remove_unreachable_it = remove_if(blocks.begin(), blocks.end(),
-        [&reachable](SAPFOR::BasicBlock* b)
-        {
-            if (reachable.find(b) == reachable.end())
-            {
-                for (auto& next : b->getNext())
-                    if (reachable.find(next) != reachable.end())
-                        next->removePrev(b);
-
-                delete b;
-                return true;
-            }
-
-            return false;
-        }
-    );
-
-    reachable.clear();
-
-    blocks.erase(remove_unreachable_it, blocks.end());
-}

src/CFGraph/CFGraph.h

@@ -6,10 +6,6 @@
 #include <vector>
 
 #include "IR.h"
-#include "../Utils/errors.h"
-#include "../Utils/utils.h"
-#include "../Utils/CommonBlock.h"
-#include "../GraphCall/graph_calls.h"
 #include "IR_domTree.h"
 
 namespace SAPFOR
@@ -45,8 +41,7 @@ namespace SAPFOR
         BasicBlock(IR_Block* item);
         BasicBlock(const BasicBlock& copyFrom);
 
-        void addInstructionBefore(IR_Block* item, Instruction* istruction);
+        void addInstruction(IR_Block* item);
-        void addInstruction(IR_Block* item, bool pushFront = false);
         void addPrev(BasicBlock* prev_) { prev.push_back(prev_); }
         void addNext(BasicBlock* next_) { next.push_back(next_); }
         void setDom(BasicBlock* dom) { directDominator = dom; }
@@ -161,5 +156,3 @@ static inline void deleteCFG(std::map<FuncInfo*, std::vector<SAPFOR::BasicBlock*
     }
     cfg.clear();
 }
-
-void removedUnreachableBlocks(std::vector<SAPFOR::BasicBlock*>& blocks);

src/CFGraph/IR.h

@@ -42,7 +42,6 @@ namespace SAPFOR
         Argument() : number(lastNumArg++), type(CFG_ARG_TYPE::NONE), value(""), mType(CFG_MEM_TYPE::NONE_) { }
         Argument(CFG_ARG_TYPE type, CFG_MEM_TYPE mType) : number(lastNumArg++), type(type), mType(mType), value("") { }
         Argument(CFG_ARG_TYPE type, CFG_MEM_TYPE mType, const std::string& value) : number(lastNumArg++), type(type), mType(mType), value(value) { }
-        Argument(CFG_ARG_TYPE type, CFG_MEM_TYPE mType, const std::string& value, int num) : number(num), type(type), mType(mType), value(value) { }
         Argument(CFG_ARG_TYPE type, const std::string& value) : number(lastNumArg++), type(type), mType(CFG_MEM_TYPE::NONE_), value(value) 
         {
             if (type != CFG_ARG_TYPE::INSTR && type == CFG_ARG_TYPE::LAB &&
@@ -51,9 +50,6 @@ namespace SAPFOR
                 printInternalError(convertFileName(__FILE__).c_str(), __LINE__);
             }
         }
-        Argument(const Argument& other)
-            : number(other.number), type(other.type), mType(other.mType), value(other.value)
-        { }
 
         void setType(CFG_ARG_TYPE newType) { type = newType; }
         CFG_ARG_TYPE getType() const { return type; }

src/CFGraph/IR_SSAForm.cpp

@@ -1,386 +0,0 @@
-#include <stdlib.h>
-#include <stdio.h>
-#include <vector>
-#include <set>
-
-#include "../Utils/SgUtils.h"
-#include "../Utils/CommonBlock.h"
-#include "../GraphCall/graph_calls.h"
-
-#include "dvm.h"
-#include "IR.h"
-#include "CFGraph.h"
-
-using namespace std;
-using namespace SAPFOR;
-
-static const SAPFOR::Argument CONST_UNDEFINED_ARG(CFG_ARG_TYPE::CONST, CFG_MEM_TYPE::COMMON_, "-1");
-
-template <typename T> static bool compareVectors(const vector<T>* vec1, const vector<T>* vec2)
-{
-    if (vec1 == vec2)
-        return true;
-    
-    if (!vec1 || !vec2)
-        return false;
-    
-    vector<T> sortedVec1 = *vec1;
-    vector<T> sortedVec2 = *vec2;
-
-    sort(sortedVec1.begin(), sortedVec1.end());
-    sort(sortedVec2.begin(), sortedVec2.end());
-
-    return sortedVec1 == sortedVec2;
-}
-
-template <typename T> static vector<T>* getCommonElements(const vector<vector<T>>* vectors)
-{
-    if (!vectors || vectors->empty())
-        return new vector<T>();
-    
-    vector<T>* commonElements = new vector<T>((*vectors)[0]);
-
-    for (size_t i = 1; i < vectors->size(); ++i) 
-    {
-        vector<T> tempCommon;
-
-        vector<T> sortedVec = (*vectors)[i];
-        sort(commonElements->begin(), commonElements->end());
-        sort(sortedVec.begin(), sortedVec.end());
-
-        set_intersection(
-            commonElements->begin(), commonElements->end(),
-            sortedVec.begin(), sortedVec.end(),
-            back_inserter(tempCommon)
-        );
-
-        *commonElements = tempCommon;
-
-        if (commonElements->empty())
-            break;
-    }
-
-    return commonElements;
-}
-
-
-static map<SAPFOR::BasicBlock*, vector<SAPFOR::BasicBlock*>> findDominators(const vector<SAPFOR::BasicBlock*>& blocks) 
-{
-    map<SAPFOR::BasicBlock*, vector<SAPFOR::BasicBlock*>> result;
-
-    bool changed = true;
-    while (changed)
-    {
-        changed = false;
-
-        for (auto& currentBlock : blocks) 
-        {
-            auto pred = currentBlock->getPrev();
-            auto prevDominators = new vector<vector<SAPFOR::BasicBlock*>>();
-
-            for (auto predBlock : pred)
-                prevDominators->push_back(result.find(predBlock) != result.end() ? result[predBlock] : blocks);
-
-            auto currentBlockResult = getCommonElements(prevDominators);
-            currentBlockResult->push_back(currentBlock);
-
-            if (result.find(currentBlock) == result.end() || !compareVectors(currentBlockResult, &result[currentBlock])) 
-            {
-                result[currentBlock] = *currentBlockResult;
-                changed = true;
-            }
-        }
-    }
-
-    return result;
-}
-
-static map<SAPFOR::BasicBlock*, vector<SAPFOR::BasicBlock*>> findDominatorBorders(const vector<SAPFOR::BasicBlock*>& blocks)
-{
-    map<SAPFOR::BasicBlock*, vector<SAPFOR::BasicBlock*>> result;
-
-    for (auto& block : blocks)
-        result[block] = *(new vector<SAPFOR::BasicBlock*>());
-
-    for (auto& block : blocks) 
-    {
-        if (block->getPrev().size() > 1) 
-        {
-            for (auto prev : block->getPrev()) 
-            {
-                auto tmpBlock = prev;
-
-                while (tmpBlock != block->getDom())
-                {
-                    result[tmpBlock].push_back(block);
-                    tmpBlock = tmpBlock->getDom();
-                }
-            }
-        }
-    }
-
-    return result;
-}
-
-static pair<set<SAPFOR::Argument*>, map<SAPFOR::Argument*, set<SAPFOR::BasicBlock*>>> getGlobalsAndVarBlocks(const vector<SAPFOR::BasicBlock*>& blocks)
-{
-    set<SAPFOR::Argument*> globals;
-    map<SAPFOR::Argument*, set<SAPFOR::BasicBlock*>> varBlocks;
-
-    for (auto& block : blocks) 
-    {
-        set<SAPFOR::Argument*> def;
-        const auto& instructions = block->getInstructions();
-
-        for (const auto& irBlock : instructions) 
-        {
-            if (irBlock) 
-            {
-                Instruction* instr = irBlock->getInstruction();
-
-                if (instr) 
-                {
-                    auto arg1 = instr->getArg1();
-                    auto arg2 = instr->getArg2();
-                    auto res = instr->getResult();
-
-                    if (arg1 && arg1->getType() == CFG_ARG_TYPE::VAR && find(def.begin(), def.end(), arg1) == def.end())
-                        globals.insert(arg1);
-
-                    if (arg2 && arg2->getType() == CFG_ARG_TYPE::VAR && find(def.begin(), def.end(), arg2) == def.end())
-                        globals.insert(arg2);
-
-                    if (res && res->getType() == CFG_ARG_TYPE::VAR) 
-                    {
-                        def.insert(res);
-                        varBlocks[res].insert(block);
-                    }
-                }
-            }
-        }
-    }
-
-    return make_pair(globals, varBlocks);
-}
-
-static void getBlocksWithFiFunctions(const vector<SAPFOR::BasicBlock*> blocks, set<SAPFOR::Argument*>& globals, 
-                                     map<SAPFOR::Argument*, set<SAPFOR::BasicBlock*>>& varBlocks, 
-                                     map<SAPFOR::BasicBlock*, vector<SAPFOR::BasicBlock*>>& dominatorBorders) 
-{
-    vector<SAPFOR::BasicBlock*> blocksWithFiFunctions;
-    auto fiFunc = new SAPFOR::Argument(CFG_ARG_TYPE::FUNC, CFG_MEM_TYPE::NONE_, "FI_FUNCTION");
-    auto paramCount = new SAPFOR::Argument(CFG_ARG_TYPE::CONST, CFG_MEM_TYPE::LOCAL_, "0");
-
-    for (auto& var : globals)
-    {
-        auto worklist = varBlocks[var];
-        set<SAPFOR::BasicBlock*> hasFiFunction;
-
-        while (!worklist.empty()) 
-        {
-            auto block = *worklist.begin();
-            worklist.erase(block);
-
-            for (auto& dfBlock : dominatorBorders[block]) 
-            {
-                if (hasFiFunction.find(dfBlock) == hasFiFunction.end()) 
-                {
-                    hasFiFunction.insert(dfBlock);
-                    Instruction* phiInstruction = new Instruction(CFG_OP::F_CALL, new SAPFOR::Argument(*fiFunc), new SAPFOR::Argument(*paramCount), var, dfBlock->getInstructions()[0]->getInstruction()->getOperator());
-
-                    IR_Block* phiBlock = new IR_Block(phiInstruction);
-                    dfBlock->addInstruction(phiBlock, true);
-                }
-            }
-        }
-    }
-}
-
-static void restoreConnections(const vector<SAPFOR::BasicBlock*>& originalBlocks, vector<SAPFOR::BasicBlock*>& copiedBlocks) 
-{
-    map<SAPFOR::BasicBlock*, SAPFOR::BasicBlock*> blockMapping;
-    for (size_t i = 0; i < originalBlocks.size(); ++i)
-        blockMapping[originalBlocks[i]] = copiedBlocks[i];
-
-    for (size_t i = 0; i < originalBlocks.size(); ++i) 
-    {
-        SAPFOR::BasicBlock* originalBlock = originalBlocks[i];
-        SAPFOR::BasicBlock* copiedBlock = copiedBlocks[i];
-
-        auto prevCopy = copiedBlock->getPrev();
-        for (auto j : prevCopy)
-            copiedBlock->removePrev(j);
-        
-        auto nextCopy = copiedBlock->getNext();
-        for (auto j : nextCopy)
-            copiedBlock->removeNext(j);
-        
-        for (auto* succ : originalBlock->getNext())
-            copiedBlock->addNext(blockMapping[succ]);
-        
-        for (auto* prev : originalBlock->getPrev())
-            copiedBlock->addPrev(blockMapping[prev]);
-    }
-}
-
-
-static SAPFOR::Argument* newName(SAPFOR::Argument* var, map<string, int>& counter, map<string, stack<SAPFOR::Argument*>>& stack, int number) {
-    counter[var->getValue()]++;
-
-    SAPFOR::Argument* newName = new SAPFOR::Argument(var->getType(), var->getMemType(), var->getValue(), number);
-    stack[var->getValue()].push(newName);
-    return newName;
-}
-
-static void renameFiFunctionResultVar(SAPFOR::BasicBlock* block, map<string, int>& counter, map<string, stack<SAPFOR::Argument*>>& stack) {
-    for (auto& irBlock : block->getInstructions()) 
-    {
-        auto instruction = irBlock->getInstruction();
-        if (instruction->getOperation() == CFG_OP::F_CALL && instruction->getArg1() != NULL &&
-            instruction->getArg1()->getValue() == "FI_FUNCTION" && instruction->getResult() != NULL)
-        {
-            instruction->setResult(newName(instruction->getResult(), counter, stack, instruction->getNumber()));
-        }
-    }
-}
-
-static void renameInstructionVars(SAPFOR::BasicBlock* block, map<string, int>& counter, map<string, stack<SAPFOR::Argument*>>& stack) 
-{
-    for (auto& irBlock : block->getInstructions()) 
-    {
-        auto instruction = irBlock->getInstruction();
-
-        if (instruction->getArg1() != NULL && instruction->getArg1()->getType() == CFG_ARG_TYPE::VAR)
-            instruction->setArg1(stack[instruction->getArg1()->getValue()].top());
-
-        if (instruction->getArg2() != NULL && instruction->getArg2()->getType() == CFG_ARG_TYPE::VAR)
-            instruction->setArg2(stack[instruction->getArg2()->getValue()].top());
-
-        if (instruction->getResult() != NULL && instruction->getResult()->getType() == CFG_ARG_TYPE::VAR)
-            instruction->setResult(newName(instruction->getResult(), counter, stack, instruction->getNumber()));
-    }
-}
-
-static void renameFiFunctionArgsVar(SAPFOR::BasicBlock* block, map<string, stack<SAPFOR::Argument*>>& stack) 
-{
-    auto size = block->getInstructions().size();
-    auto& instructions = block->getInstructions();
-
-    for (size_t i = 0; i < size; ++i) 
-    {
-        auto irBlock = instructions[i];
-        auto instruction = irBlock->getInstruction();
-        if (instruction->getOperation() == CFG_OP::F_CALL && instruction->getArg1() != NULL && 
-            instruction->getArg1()->getValue() == "FI_FUNCTION" && instruction->getResult() != NULL && 
-            instruction->getArg2() != NULL) 
-        {
-            Instruction* paramInstruction;
-            
-            if (stack[instruction->getResult()->getValue()].size() > 0) 
-            {
-                SAPFOR::Argument* tmp = new SAPFOR::Argument(CFG_ARG_TYPE::CONST, CFG_MEM_TYPE::COMMON_, to_string(stack[instruction->getResult()->getValue()].top()->getNumber()));
-                paramInstruction = new Instruction(CFG_OP::PARAM, tmp);
-            }
-            else 
-            {
-                SAPFOR::Argument* tmp = new SAPFOR::Argument(CFG_ARG_TYPE::CONST, CFG_MEM_TYPE::COMMON_, "-1");
-                paramInstruction = new Instruction(CFG_OP::PARAM, tmp);
-            }
-
-            paramInstruction->setOperator(block->getInstructions()[0]->getInstruction()->getOperator());
-            block->addInstructionBefore(new IR_Block(paramInstruction), instruction);
-
-            instruction->getArg2()->setValue(to_string(stoi(instruction->getArg2()->getValue()) + 1));
-            i++;
-        }
-    }
-}
-
-static vector<SAPFOR::BasicBlock*> findBlocksWithValue(vector<SAPFOR::BasicBlock*>& blocks, SAPFOR::BasicBlock* x) 
-{
-    vector<SAPFOR::BasicBlock*> result;
-
-    for (auto& block : blocks)
-        if (block->getDom() == x)
-            result.push_back(block);
-
-    return result;
-}
-
-static void renameIR(SAPFOR::BasicBlock* block, vector<SAPFOR::BasicBlock*>& blocks, map<string, int>& counter, map<string, stack<SAPFOR::Argument*>>& stack)
-{
-    renameFiFunctionResultVar(block, counter, stack);
-    renameInstructionVars(block, counter, stack);
-
-    for (auto& successor : block->getNext())
-        renameFiFunctionArgsVar(successor, stack);
-    
-    for (auto& child : findBlocksWithValue(blocks, block))
-        renameIR(child, blocks, counter, stack);
-
-    for (auto& irBlock : block->getInstructions())
-    {
-        auto instruction = irBlock->getInstruction();
-        if (instruction->getResult() != NULL && instruction->getResult()->getType() == CFG_ARG_TYPE::VAR) 
-        {
-            string varName = instruction->getResult()->getValue();
-            stack[varName].pop();
-        }
-    }
-
-    for (auto& irBlock : block->getInstructions()) 
-    {
-        auto instruction = irBlock->getInstruction();
-        if (instruction->getOperation() == CFG_OP::F_CALL && instruction->getArg1() != NULL && 
-            instruction->getArg1()->getValue() == "FI_FUNCTION" && instruction->getResult() != NULL) 
-        {
-            string varName = instruction->getResult()->getValue();
-            stack[varName].pop();
-        }
-    }
-}
-
-void buildFuncIRSSAForm(FuncInfo* funcInfo, const std::vector<SAPFOR::BasicBlock*>& funcIRConst, std::map<FuncInfo*, std::vector<SAPFOR::BasicBlock*>>& result)
-{
-    vector<SAPFOR::BasicBlock*> funcIR;
-
-    for (auto& i : funcIRConst)
-        funcIR.push_back(new SAPFOR::BasicBlock(*i));
-
-    restoreConnections(funcIRConst, funcIR);
-
-    SAPFOR::buildDominatorTree(funcIR);
-
-    auto dominatorBorders = findDominatorBorders(funcIR);
-
-    auto globalsAndVarBlocks = getGlobalsAndVarBlocks(funcIR);
-    auto globals = globalsAndVarBlocks.first;
-    auto varBlocks = globalsAndVarBlocks.second;
-
-    getBlocksWithFiFunctions(funcIR, globals, varBlocks, dominatorBorders);
-
-    map<string, int> count;
-    map<string, stack<SAPFOR::Argument*>> varStack;
-
-    for (auto& var : globals)
-    {
-        count[var->getValue()] = 0;
-
-        stack<SAPFOR::Argument*> tmp;
-        tmp.push(new SAPFOR::Argument(CONST_UNDEFINED_ARG));
-        varStack[var->getValue()] = tmp;
-    }
-
-    renameIR(funcIR[0], funcIR, count, varStack);
-
-    result[funcInfo] = funcIR;
-}
-
-FuncInfo* getIRByFilename(const std::map<FuncInfo*, std::vector<SAPFOR::BasicBlock*>>& fullIR, const char* filename)
-{
-    for (auto ir : fullIR)
-        if (ir.first->fileName == filename)
-            return ir.first;
-
-    return nullptr;
-}

src/CFGraph/IR_SSAForm.h

@@ -1,8 +0,0 @@
-#pragma once
-
-#include "CFGraph.h"
-#include "IR.h"
-
-void buildFuncIRSSAForm(FuncInfo* funcInfo, const std::vector<SAPFOR::BasicBlock*>& fullIR, std::map<FuncInfo*, std::vector<SAPFOR::BasicBlock*>>& result);
-
-FuncInfo* getIRByFilename(const std::map<FuncInfo*, std::vector<SAPFOR::BasicBlock*>>& fullIR, const char* filename);

src/CFGraph/IR_domTree.h

@@ -7,7 +7,7 @@
 #include "CFGraph.h"
 
 // Lengauer, Thomas. A fast algorithm for finding dominators in a flowgraph / Thomas Lengauer, Robert Endre Tarjan 
-// ACM Transactions on Programming Languages and Systems (TOPLAS). <20> 1979. <20> Vol. 1, no. 1. <20> Pp. 121<32>141.
+// ACM Transactions on Programming Languages and Systems (TOPLAS). <20> 1979. <20> Vol. 1, no. 1. <20> Pp. 121<32>141.
 
 namespace SAPFOR {
 

src/CFGraph/private_variables_analysis.cpp

@@ -250,7 +250,7 @@ static set<SAPFOR::BasicBlock*> analyzeLoop(LoopGraph* loop, const set<SAPFOR::B
                                             const map<string, SgSymbol*>& commonArgs, FuncInfo* func,
                                             map<string, vector<Messages>>& messages)
 {
-    if (!loop->isFor())
+    if (!loop->isFor)
         printInternalError(convertFileName(__FILE__).c_str(), __LINE__); //should be called only with FOR loops
 
     SgStatement* loop_operator = loop->loop->GetOriginal();
@@ -450,7 +450,7 @@ static void recAnalyzeLoop(LoopGraph* loop, const set<SAPFOR::BasicBlock*>& bloc
                            const map<string, SgSymbol*>& commonArgs,
                            FuncInfo* func, map<string, vector<Messages>>& messages)
 {
-    const auto& loop_body = loop->isFor() ? analyzeLoop(loop, blocks, commonVars, commonArgs, func, messages) : blocks;
+    const auto& loop_body = loop->isFor ? analyzeLoop(loop, blocks, commonVars, commonArgs, func, messages) : blocks;
     
     for (const auto& inner_loop : loop->children)
         recAnalyzeLoop(inner_loop, loop_body, commonVars, commonArgs, func, messages);

src/DirectiveProcessing/directive_creator_base.cpp

@@ -75,7 +75,7 @@ static LoopGraph* createDirectiveForLoop(LoopGraph *currentLoop, MapToArray &mai
         }
     }
 
-    directive->parallel.push_back(currentLoop->loopSymbol());
+    directive->parallel.push_back(currentLoop->loopSymbol);
     directive->arrayRef = mainArray.arrayRef;
 
     DIST::Array *tmp = mainArray.arrayRef;
@@ -84,7 +84,7 @@ static LoopGraph* createDirectiveForLoop(LoopGraph *currentLoop, MapToArray &mai
         for (int i = 0; i < tmp->GetDimSize(); ++i)
         {
             if (i == pos)
-                directive->on.push_back(make_pair(currentLoop->loopSymbol(), mainAccess));
+                directive->on.push_back(make_pair(currentLoop->loopSymbol, mainAccess));
             else
                 directive->on.push_back(make_pair("*", make_pair(0, 0)));
         }
@@ -808,7 +808,7 @@ void createParallelDirectives(const map<LoopGraph*, map<DIST::Array*, ArrayInfo*
                             for (int i = 0; i < mainArrayOfLoop->GetDimSize(); ++i)
                             {
                                 if (i == dimPos)
-                                    parDir->on2.push_back(make_pair(currLoop->loopSymbol(), mainAccess));
+                                    parDir->on2.push_back(make_pair(currLoop->loopSymbol, mainAccess));
                                 else
                                     parDir->on2.push_back(make_pair("*", make_pair(0, 0)));
                             }
@@ -1100,7 +1100,7 @@ static bool tryToResolveUnmatchedDims(const map<DIST::Array*, vector<bool>> &dim
     LoopGraph* tmpL = loop;
     for (int z = 0; z < nested; ++z)
     {
-        deprecateToMatch.insert(tmpL->loopSymbol());
+        deprecateToMatch.insert(tmpL->loopSymbol);
         if (tmpL->children.size())
             tmpL = tmpL->children[0];
         else if (z != nested - 1)
@@ -1113,7 +1113,7 @@ static bool tryToResolveUnmatchedDims(const map<DIST::Array*, vector<bool>> &dim
     tmpL = loop->parent;
     while (tmpL)
     {
-        if (tmpL->isWhile()) // TODO: need to add all inductive variables!
+        if (!tmpL->isFor) // TODO: need to add all inductive variables!
         {
             SgWhileStmt* dow = isSgWhileStmt(tmpL->loop->GetOriginal());
             if (dow->conditional())
@@ -1124,7 +1124,7 @@ static bool tryToResolveUnmatchedDims(const map<DIST::Array*, vector<bool>> &dim
             }
         }
         else
-            deprecateToMatch.insert(tmpL->loopSymbol());
+            deprecateToMatch.insert(tmpL->loopSymbol);
         tmpL = tmpL->parent;
     }
 

src/Distribution/DvmhDirective.cpp

@@ -346,7 +346,7 @@ static vector<SgExpression*>
                             {
                                 needToAdd = true;
                                 dim_found = true;
-                                subs[i] = new SgVarRefExp(findSymbolOrCreate(file, currLoop->loopSymbol()));
+                                subs[i] = new SgVarRefExp(findSymbolOrCreate(file, currLoop->loopSymbol));
                                 break;
                             }
                         }

src/GraphLoop/graph_loops.cpp

@@ -699,12 +699,7 @@ void loopGraphAnalyzer(SgFile *file, vector<LoopGraph*> &loopGraph, const vector
                 newLoop->hasPrints = hasThisIds(st, newLoop->linesOfIO, { WRITE_STAT, READ_STAT, OPEN_STAT, CLOSE_STAT, PRINT_STAT } ); // FORMAT_STAT
                 newLoop->hasStops = hasThisIds(st, newLoop->linesOfStop, { STOP_STAT, PAUSE_NODE });
                 newLoop->hasDvmIntervals = hasThisIds(st, tmpLines, { DVM_INTERVAL_DIR, DVM_ENDINTERVAL_DIR, DVM_EXIT_INTERVAL_DIR });
-                if (isSgForStmt(st))
+                newLoop->isFor = isSgForStmt(st) ? true : false;
-                    newLoop->loopType = LoopType::FOR;
-                else if (isSgWhileStmt(st))
-                    newLoop->loopType = LoopType::WHILE;
-                else 
-                    newLoop->loopType = LoopType::NONE;
                 newLoop->inCanonicalFrom = isSgForStmt(st) ? true : false;
                 newLoop->hasSubstringRefs = hasSubstringRef(st);
 
@@ -782,7 +777,7 @@ void loopGraphAnalyzer(SgFile *file, vector<LoopGraph*> &loopGraph, const vector
                     newLoop->startEndExpr = std::make_pair((Expression*)NULL, (Expression*)NULL);
 
                 newLoop->loop = new Statement(st);
-                newLoop->loopSymbols.addMainVar(st->symbol() ? st->symbol()->identifier() : "unknown");
+                newLoop->loopSymbol = st->symbol() ? st->symbol()->identifier() : "unknown";
                 findArrayRefs(newLoop);
 
                 SgStatement *lexPrev = st->lexPrev();

src/GraphLoop/graph_loops.h

@@ -25,33 +25,6 @@ namespace DIST = Distribution;
 void getRealArrayRefs(DIST::Array* addTo, DIST::Array* curr, std::set<DIST::Array*>& realArrayRefs, const std::map<DIST::Array*, std::set<DIST::Array*>>& arrayLinksByFuncCalls);
 void getAllArrayRefs(DIST::Array* addTo, DIST::Array* curr, std::set<DIST::Array*>& realArrayRefs, const std::map<DIST::Array*, std::set<DIST::Array*>>& arrayLinksByFuncCalls);
 
-enum class LoopType { NONE, FOR, WHILE, IMPLICIT };
-
-struct InductiveVariables
-{
-private:
-    std::string mainVar;
-    std::set<std::string> allVars;
-
-public:
-    InductiveVariables() { }
-
-    explicit InductiveVariables(const std::string& mainVar, const std::set<std::string>& allVars) : mainVar(mainVar), allVars(allVars) { };
-
-    std::string getMainVar() const { return mainVar; }
-    std::set<std::string> getAllVars() const { return allVars; }
-
-    void addVar(const std::string& var) { allVars.insert(var); }
-    void addMainVar(const std::string& var) { mainVar = var; allVars.insert(var); }
-
-    void replaceMainVar(const std::string& var) 
-    {
-        allVars.erase(mainVar);
-
-        addMainVar(var);
-    }
-};
-
 struct LoopGraph
 {
 private:
@@ -97,7 +70,7 @@ public:
         calculatedCountOfIters = 0;
         executionTimeInSec = -1.0;
         inDvmhRegion = 0;
-        loopType = LoopType::NONE;
+        isFor = false;
         inCanonicalFrom = false;
         hasAccessToSubArray = false;
         hasSubstringRefs = false;
@@ -140,24 +113,21 @@ public:
     {
         return hasUnknownArrayDep || hasUnknownScalarDep || hasGoto || hasPrints || (hasConflicts.size() != 0) || hasStops || hasNonPureProcedures ||
                hasUnknownArrayAssigns || hasNonRectangularBounds || hasIndirectAccess || hasWritesToNonDistribute || hasDifferentAlignRules || hasDvmIntervals ||
-               !isFor() || lastprivateScalars.size() || hasAccessToSubArray || hasSubstringRefs;
+               !isFor || lastprivateScalars.size() || hasAccessToSubArray || hasSubstringRefs;
     }
     
     bool hasLimitsToSplit() const
     {
-        return hasGoto || hasStops || !isFor() || hasPrints;
+        return hasGoto || hasStops || !isFor || hasPrints;
     }
 
     bool hasLimitsToCombine() const
     {
-        return hasGoto || hasStops || !isFor() || hasPrints || linesOfCycle.size();
+        return hasGoto || hasStops || !isFor || hasPrints || linesOfCycle.size();
     }
 
     void addConflictMessages(std::vector<Messages> *messages)
     {
-        if (messages == NULL)
-            return;
-
         const int line = altLineNum > 0 ? altLineNum : lineNum;
         if (hasUnknownArrayDep)
             messages->push_back(Messages(NOTE, line, R113, L"unknown array dependency prevents parallelization of this loop", 3006));
@@ -198,7 +168,7 @@ public:
         if (hasDvmIntervals)
             messages->push_back(Messages(NOTE, line, R145, L"DVM intervals prevent parallelization of this loop", 3006));
 
-        if (!isFor() || !inCanonicalFrom)
+        if (!isFor || !inCanonicalFrom)
             messages->push_back(Messages(NOTE, line, R178, L"This type of loop is not supported by the system", 3006));
 
         if (lastprivateScalars.size())
@@ -423,14 +393,6 @@ public:
 
     void* getRealStat(const char* file) const;
 
-    bool isFor() const { return loopType == LoopType::FOR; }
-
-    bool isWhile() const { return loopType == LoopType::WHILE; }
-
-    bool isImplicit() const { return loopType == LoopType::IMPLICIT; }
-
-    std::string loopSymbol() const { return loopSymbols.getMainVar(); }
-
 public:
     int lineNum;
     int altLineNum;
@@ -445,7 +407,7 @@ public:
     int startVal, endVal, stepVal;
     std::tuple<Expression*, Expression*, Expression*> startEndStepVals;
 
-    InductiveVariables loopSymbols;
+    std::string loopSymbol;
     std::pair<Expression*, Expression*> startEndExpr;
 
     bool hasGoto;
@@ -486,7 +448,7 @@ public:
 
     bool hasSubstringRefs;
 
-    LoopType loopType;
+    bool isFor;
 
     bool inCanonicalFrom;
     

src/GraphLoop/graph_loops_base.cpp

@@ -551,7 +551,7 @@ void addToDistributionGraph(const map<LoopGraph*, map<DIST::Array*, ArrayInfo*>>
             continue;
         }
 
-        if (!loopAccess.first->isFor())
+        if (!loopAccess.first->isFor)
             continue;
 
         DIST::GraphCSR<int, double, attrType>& G = currReg->GetGraphToModify();
@@ -775,7 +775,7 @@ static void isAllOk(const vector<LoopGraph*> &loops, vector<Messages> &currMessa
     {
         if (loops[i]->region)
         {            
-            if (loops[i]->countOfIters == 0 && loops[i]->region && loops[i]->isFor())
+            if (loops[i]->countOfIters == 0 && loops[i]->region && loops[i]->isFor)
             {
                 wstring bufE, bufR;
                 __spf_printToLongBuf(bufE, L"  Can not calculate count of iterations for this loop, information about iterations in all loops in parallel regions '%s' will be ignored", 

src/LoopAnalyzer/implicit_loops_analyzer.cpp

@@ -1,281 +0,0 @@
-#include <map>
-#include <set>
-#include <vector>
-#include <string>
-#include <iostream>
-#include <stack>
-
-#include "../CFGraph/IR.h"
-#include "GraphCall/graph_calls.h"
-#include "implicit_loops_analyzer.h"
-
-using namespace std;
-using namespace SAPFOR;
-
-using std::map;
-using std::set;
-using std::vector;
-using std::pair;
-using std::string;
-using std::cout;
-using std::endl;
-using std::make_pair;
-using std::to_string;
-
-enum VisitState { UNVISITED = 0, VISITING = 1, VISITED = 2 };
-
-void dfs(SAPFOR::BasicBlock* block,
-    std::map<int, int>& visit,
-    std::vector<std::pair<SAPFOR::BasicBlock*, SAPFOR::BasicBlock*>>& startAndEnd,
-    SAPFOR::BasicBlock* prev)
-{
-    if (!block)
-        return;
-
-    int id = block->getNumber();
-
-    if (visit[id] == VISITING) {
-        startAndEnd.emplace_back(prev, block);
-        return;
-    }
-
-    if (visit[id] == VISITED)
-        return;
-
-    visit[id] = VISITING;
-
-    for (auto next : block->getNext())
-        dfs(next, visit, startAndEnd, block);
-
-    visit[id] = VISITED;
-}
-
-void getLoopBody(SAPFOR::BasicBlock* loopHeader, const std::set<SAPFOR::BasicBlock*>& loopExits, std::vector<SAPFOR::BasicBlock*>& loopBody)
-{
-    std::set<SAPFOR::BasicBlock*> visited;
-    std::stack<SAPFOR::BasicBlock*> stack;
-
-    stack.push(loopHeader);
-
-    while (!stack.empty())
-    {
-        auto block = stack.top();
-        stack.pop();
-
-        if (visited.count(block))
-            continue;
-        visited.insert(block);
-
-        for (auto succ : block->getNext())
-        {
-            if (loopExits.count(succ))
-                continue;
-            if (!visited.count(succ))
-                stack.push(succ);
-        }
-    }
-
-    std::set<SAPFOR::BasicBlock*> backReachable;
-    std::stack<SAPFOR::BasicBlock*> reverseStack;
-    reverseStack.push(loopHeader);
-
-    while (!reverseStack.empty())
-    {
-        auto block = reverseStack.top();
-        reverseStack.pop();
-
-        if (backReachable.count(block))
-            continue;
-        backReachable.insert(block);
-
-        for (auto pred : block->getPrev())
-            if (visited.count(pred) && !backReachable.count(pred))
-                reverseStack.push(pred);
-    }
-
-    for (auto block : visited)
-        if (backReachable.count(block))
-            loopBody.push_back(block);
-}
-
-SAPFOR::Instruction* findDef(const SAPFOR::Argument* arg,
-    const std::vector<SAPFOR::BasicBlock*>& blocks)
-{
-    if (!arg)
-        return nullptr;
-    std::string argName = arg->getValue();
-
-    for (auto block : blocks) {
-        for (auto instrWrapper : block->getInstructions()) {
-            auto instr = instrWrapper->getInstruction();
-            if (!instr)
-                continue;
-
-            auto res = instr->getResult();
-            if (!res)
-                continue;
-
-            if (res->getValue() == argName)
-                return instr;
-        }
-    }
-
-    return nullptr;
-}
-
-const SAPFOR::Argument* getBaseSource(const SAPFOR::Argument* arg, const std::vector<SAPFOR::BasicBlock*>& blocks)
-{
-    while (arg && arg->getType() == CFG_ARG_TYPE::REG)
-    {
-        auto defInstr = findDef(arg, blocks);
-        if (!defInstr)
-            break;
-        auto defOp = defInstr->getOperation();
-
-        if (defOp == CFG_OP::ASSIGN)
-            arg = defInstr->getArg1();
-        else
-            break;
-    }
-    return arg;
-}
-
-void findInductiveVars(const std::vector<SAPFOR::BasicBlock*>& Loopblocks, const std::vector<SAPFOR::BasicBlock*>& blocks)
-{
-    std::set<std::string> inductiveVars;
-
-    for (auto block : Loopblocks)
-    {
-        for (auto instrWrapper : block->getInstructions())
-        {
-            auto instr = instrWrapper->getInstruction();
-            if (!instr)
-                continue;
-
-            auto res = instr->getResult();
-            if (!res || res->getType() != SAPFOR::CFG_ARG_TYPE::VAR)
-                continue;
-
-            while (instr && instr->getOperation() == CFG_OP::ASSIGN)
-                instr = findDef(instr->getArg1(), blocks);
-
-            if (!instr || instr->getOperation() != CFG_OP::ADD && instr->getOperation() != CFG_OP::SUBT)
-                continue;
-
-            auto arg1 = getBaseSource(instr->getArg1(), blocks);
-            auto arg2 = getBaseSource(instr->getArg2(), blocks);
-
-            bool ok = false;
-            if (res->getValue() == arg1->getValue() && arg2->getType() == CFG_ARG_TYPE::CONST)
-                ok = true;
-            else if (res->getValue() == arg2->getValue() && arg1->getType() == CFG_ARG_TYPE::CONST)
-                ok = true;
-
-            if (ok)
-                inductiveVars.insert(res->getValue());
-        }
-    }
-
-    if (inductiveVars.empty())
-        std::cout << "No inductive variables found." << std::endl;
-    else
-        for (const auto& var : inductiveVars)
-            std::cout << "Inductive variable: " << var << std::endl;
-}
-
-Instruction* findInstructionAfterLoop(const std::vector<SAPFOR::BasicBlock*>& loopBody)
-{
-    std::set<SAPFOR::BasicBlock*> loopSet(loopBody.begin(), loopBody.end());
-
-    for (auto block : loopBody)
-    {
-        for (auto succ : block->getNext())
-        {
-            if (!loopSet.count(succ))
-            {
-                auto instructions = succ->getInstructions();
-                if (instructions.empty())
-                    std::cout << "Exit block has no instructions." << std::endl;
-
-                for (auto wrapper : instructions)
-                    if (auto instr = wrapper->getInstruction())
-                        return instr;
-            }
-        }
-    }
-
-    return nullptr;
-}
-
-void findImplicitLoops(const std::vector<SAPFOR::BasicBlock*>& irSSA, const std::vector<LoopGraph*> loopGraph)
-{
-    map<int, int> visited;
-    for (auto i : irSSA)
-        visited[i->getNumber()] = UNVISITED;
-
-    vector<pair<SAPFOR::BasicBlock*, SAPFOR::BasicBlock*>> startAndEnd;
-    dfs(irSSA[0], visited, startAndEnd, NULL);
-
-    vector<LoopGraph*> loops;
-
-    for (auto& [tail, header] : startAndEnd)
-    {
-        set<SAPFOR::BasicBlock*> loopExits;
-
-        for (auto succ : tail->getNext())
-            if (succ != header)
-                loopExits.insert(succ);
-
-        vector<SAPFOR::BasicBlock*> loopBody;
-        getLoopBody(header, loopExits, loopBody);
-
-        findInductiveVars(loopBody, irSSA);
-
-        Instruction* instructionAfterLoop = findInstructionAfterLoop(loopBody);
-
-        if (instructionAfterLoop == NULL)
-        {
-            cout << "Warning: instruction after loop not found!" << endl;
-            continue;
-        }
-
-        auto firstInstruction = header->getInstructions()[0]->getInstruction();
-        auto lastInstruction = tail->getInstructions().back()->getInstruction();
-        auto tmpLoop = new LoopGraph();
-        tmpLoop->lineNum = firstInstruction->getOperator()->lineNumber();
-        tmpLoop->lineNumAfterLoop = instructionAfterLoop->getOperator()->lineNumber();
-
-
-        if (firstInstruction->getOperator()->variant() == FOR_NODE) 
-        {
-            SgForStmt* stmt = isSgForStmt(firstInstruction->getOperator());
-
-            cout << "for loop" << endl;
-        }
-        else if (firstInstruction->getOperator()->variant() == WHILE_NODE) 
-        {
-            SgWhileStmt* stmt = isSgWhileStmt(firstInstruction->getOperator());
-
-            cout << (stmt->conditional() == NULL ? "infinit" : "") << "while loop" << endl;
-        }
-        else if (firstInstruction->getOperator()->variant() == DO_WHILE_NODE) 
-        {
-            SgWhileStmt* stmt = isSgDoWhileStmt(firstInstruction->getOperator());
-
-            cout << "do while loop" << endl;
-        }
-        else if (firstInstruction->getOperator()->variant() == LOOP_NODE) 
-        {
-            cout << "not known loop" << endl;
-        }
-        else
-        {
-            cout << "goto loop" << endl;
-        }
-
-        cout << "loop start line " << tmpLoop->lineNum << endl;
-        cout << "after loop line " << tmpLoop->lineNumAfterLoop << endl << endl;
-
-        loops.push_back(tmpLoop);
-    }
-}

src/LoopAnalyzer/implicit_loops_analyzer.h

@@ -1,7 +0,0 @@
-#pragma once
-
-#include <map>
-#include "../CFGraph/CFGraph.h"
-#include "../GraphCall/graph_calls.h"
-
-void findImplicitLoops(const std::vector<SAPFOR::BasicBlock*>& fullIR_SSA, const std::vector<LoopGraph*> loopGraph);

src/LoopAnalyzer/loop_analyzer.cpp

@@ -2199,7 +2199,7 @@ void loopAnalyzer(SgFile *file, vector<ParallelRegion*> &regions, map<tuple<int,
                             LoopGraph *tmpLoop = new LoopGraph();
 
                             tmpLoop->region = reg;
-                            tmpLoop->loopType = LoopType::FOR;
+                            tmpLoop->isFor = true;
 
                             tmpLoops.push_back(tmpLoop);
 

src/PrivateAnalyzer/private_arrays_search.cpp

@@ -121,7 +121,7 @@ static void SolveDataFlow(Region* DFG)
     Collapse(DFG);
 }
 
-map<LoopGraph*, ArrayAccessingIndexes>  findPrivateArrays(map<string, vector<LoopGraph*>> &loopGraph, map<FuncInfo*, vector<SAPFOR::BasicBlock*>>& FullIR)
+map<LoopGraph*, ArrayAccessingIndexes>  FindPrivateArrays(map<string, vector<LoopGraph*>> &loopGraph, map<FuncInfo*, vector<SAPFOR::BasicBlock*>>& FullIR)
 {  
     map<LoopGraph*, ArrayAccessingIndexes> result;
     for (const auto& [loopName, loops] : loopGraph)

src/PrivateAnalyzer/private_arrays_search.h

@@ -10,5 +10,5 @@
 #include "../CFGraph/CFGraph.h"
 
 void Collapse(Region* region);
-std::map<LoopGraph*, ArrayAccessingIndexes> findPrivateArrays(std::map<std::string, std::vector<LoopGraph*>>& loopGraph, std::map<FuncInfo*, std::vector<SAPFOR::BasicBlock*>>& FullIR);
+std::map<LoopGraph*, ArrayAccessingIndexes> FindPrivateArrays(std::map<std::string, std::vector<LoopGraph*>>& loopGraph, std::map<FuncInfo*, std::vector<SAPFOR::BasicBlock*>>& FullIR);
 std::pair<SAPFOR::BasicBlock*, std::unordered_set<SAPFOR::BasicBlock*>> GetBasicBlocksForLoop(const LoopGraph* loop, const std::vector<SAPFOR::BasicBlock*> blocks);

src/PrivateAnalyzer/region.cpp

@@ -51,7 +51,7 @@ pair<SAPFOR::BasicBlock*, unordered_set<SAPFOR::BasicBlock*>> GetBasicBlocksForL
 }
 
 static void BuildLoopIndex(map<string, LoopGraph*>& loopForIndex, LoopGraph* loop) {
-    string index = loop->loopSymbol();
+    string index = loop->loopSymbol;
     loopForIndex[index] = loop;
 
     for (const auto& childLoop : loop->children)

src/Sapfor.cpp

@@ -40,7 +40,6 @@
 #include "ProjectManipulation/ConvertFiles.h"
 
 #include "LoopAnalyzer/loop_analyzer.h"
-#include "LoopAnalyzer/implicit_loops_analyzer.h"
 
 #include "GraphCall/graph_calls_func.h"
 #include "GraphLoop/graph_loops_func.h"
@@ -96,7 +95,6 @@
 #include "CFGraph/IR.h"
 #include "CFGraph/RD_subst.h"
 #include "CFGraph/CFGraph.h"
-#include "CFGraph/IR_SSAForm.h"
 
 #include "CFGraph/live_variable_analysis.h"
 #include "CFGraph/private_variables_analysis.h"
@@ -1021,19 +1019,8 @@ static bool runAnalysis(SgProject &project, const int curr_regime, const bool ne
                 if(func->funcPointer->variant() != ENTRY_STAT)
                     countOfTransform += removeDeadCode(func->funcPointer, allFuncInfo, commonBlocks);
         }
-        else if (curr_regime == BUILD_IR_SSA_FORM)
-        {
-            auto irFound = getIRByFilename(fullIR, file_name);
-            buildFuncIRSSAForm(irFound, fullIR[irFound], fullIR_SSA);
-        }
-        else if (curr_regime == FIND_IMPLICIT_LOOPS)
-        {
-            auto itFound = loopGraph.find(file_name);
-            auto irFound = getIRByFilename(fullIR_SSA, file_name);
-            findImplicitLoops(fullIR_SSA[irFound], itFound->second);
-        }         
         else if (curr_regime == FIND_PRIVATE_ARRAYS)
-            findPrivateArrays(loopGraph, fullIR);
+            FindPrivateArrays(loopGraph, fullIR);
         else if (curr_regime == TEST_PASS)
         {
         //test pass

src/Sapfor.h

@@ -182,8 +182,6 @@ enum passes {
 
     SET_IMPLICIT_NONE,
     RENAME_INLCUDES,
-    FIND_IMPLICIT_LOOPS,
-    BUILD_IR_SSA_FORM,
 
     FIND_PRIVATE_ARRAYS,
 
@@ -371,8 +369,6 @@ static void setPassValues()
     passNames[SET_IMPLICIT_NONE] = "SET_IMPLICIT_NONE";
     passNames[RENAME_INLCUDES] = "RENAME_INLCUDES";
     passNames[INSERT_NO_DISTR_FLAGS_FROM_GUI] = "INSERT_NO_DISTR_FLAGS_FROM_GUI";
-    passNames[FIND_IMPLICIT_LOOPS] = "FIND_IMPLICIT_LOOPS";
-    passNames[BUILD_IR_SSA_FORM] = "BUILD_IR_SSA_FORM";
     passNames[FIND_PRIVATE_ARRAYS] = "FIND_PRIVATE_ARRAYS";
 
     passNames[TEST_PASS] = "TEST_PASS";

src/SapforData.h

@@ -181,7 +181,3 @@ bool passNamesWasInit = false;
 
 std::map<PTR_BFND, std::pair<std::string, int>> sgStats;
 std::map<PTR_LLND, std::pair<std::string, int>> sgExprs;
-
-//for FIND_IMPLICIT_LOOPS and BUILD_IR_SSA_FORM
-map<FuncInfo*, vector<SAPFOR::BasicBlock*>> fullIR_SSA;
-//

src/Transformations/DeadCodeRemoving/dead_code.cpp

@@ -6,8 +6,6 @@
 #include <set>
 #include <algorithm>
 
-#include "../../CFGraph/CFGraph.h"
-
 using std::map;
 using std::string;
 using std::vector;
@@ -90,13 +88,13 @@ static void updateUseDefForInstruction(SAPFOR::BasicBlock* block, SAPFOR::Instru
             instr_operation == SAPFOR::CFG_OP::STORE)
             last_stack_op_useful = true;
 
-        for (auto& e : res)
+        for (auto e : res)
         {
             def.insert(e);
             use.erase(e);
         }
 
-        for (auto& e : args)
+        for (auto e : args)
         {
             use.insert(e);
             def.erase(e);
@@ -166,7 +164,7 @@ public:
         {
             const auto& example = dynamic_cast<DeadCodeAnalysisNode*>(*prev.begin())->next_notempty_out;
             
-            for (auto& p : prev)
+            for (auto p : prev)
             {
                 DeadCodeAnalysisNode* next = dynamic_cast<DeadCodeAnalysisNode*>(p);
 
@@ -190,7 +188,7 @@ public:
         {
             set<DeadCodeAnalysisNode*> current = {};
 
-            for (auto& nextP : getPrevBlocks())
+            for (auto nextP : getPrevBlocks())
             {
                 DeadCodeAnalysisNode* next = dynamic_cast<DeadCodeAnalysisNode*>(nextP);
 
@@ -430,7 +428,49 @@ int removeDeadCode(SgStatement* func,
         printInternalError(convertFileName(__FILE__).c_str(), __LINE__);
 
     auto& cfg_pair = *(cfg.begin());
-    removedUnreachableBlocks(cfg_pair.second);
+
+    // delete unreachable blocks
+
+    set<SAPFOR::BasicBlock*> reachable;
+
+    for (auto b : cfg_pair.second)
+        if(b->getInstructions().front()->isHeader() || 
+           b->getInstructions().front()->getInstruction()->getOperation() == SAPFOR::CFG_OP::ENTRY)
+            reachable.insert(b);
+
+    set<SAPFOR::BasicBlock*> worklist = reachable;
+    while (worklist.size() != 0)
+    {
+        set<SAPFOR::BasicBlock*> to_insert;
+
+        for(auto b : worklist)
+            for(auto next: b->getNext())
+                if(reachable.insert(next).second)
+                    to_insert.insert(next);
+
+        worklist = to_insert;
+    }
+
+    auto remove_unreachable_it = remove_if(cfg_pair.second.begin(), cfg_pair.second.end(), 
+        [&reachable](SAPFOR::BasicBlock* b)
+        {
+            if (reachable.find(b) == reachable.end())
+            {
+                for(auto next: b->getNext())
+                    if(reachable.find(next) != reachable.end())
+                        next->removePrev(b);
+
+                delete b;
+                return true;
+            }
+
+            return false;
+        }
+    );
+
+    reachable.clear();
+
+    cfg_pair.second.erase(remove_unreachable_it, cfg_pair.second.end());
 
 #if DEBUG_IR
     dumpCFG({ cfg_pair }, false);
@@ -441,7 +481,7 @@ int removeDeadCode(SgStatement* func,
     map<string, FuncInfo*> funcByName;
 
     for (auto& byFile : allFuncs)
-        for (auto& byFunc : byFile.second)
+        for (auto byFunc : byFile.second)
             funcByName[byFunc->funcName] = byFunc;
 
     DeadCodeAnalysis analysis_object(func_parameters, funcByName);

src/Transformations/LoopCombining/loops_combiner.cpp

@@ -20,7 +20,7 @@ using std::wstring;
 
 static SgSymbol* getLoopSymbol(const LoopGraph* loop)
 {
-    if (!loop || !loop->isFor())
+    if (!loop || !loop->isFor)
         return NULL;
 
     SgForStmt* stmt = (SgForStmt*)loop->loop->GetOriginal();
@@ -667,12 +667,12 @@ static void renameIterationVariables(LoopGraph* loop, const map<SgSymbol*, SgSym
 {
     if (loop)
     {
-        const string& loopName = loop->loopSymbol();
+        string& loopName = loop->loopSymbol;
-        for (auto& [from, to] : symbols)
+        for (auto& pair : symbols)
         {
-            if (from->identifier() == loopName)
+            if (pair.first->identifier() == loopName)
             {
-                loop->loopSymbols.replaceMainVar(to->identifier());
+                loop->loopSymbol = (string)pair.second->identifier();
                 break;
             }
         }
@@ -691,9 +691,9 @@ static void renameVariablesInLoop(LoopGraph* loop, const map<SgSymbol*, SgSymbol
         if (st->variant() == FOR_NODE)
         {
             SgForStmt* for_st = (SgForStmt*)st;
-            for (auto& [from, to] : symbols)
+            for (auto& pair : symbols)
-                if (isEqSymbols(from, for_st->symbol()))
+                if (isEqSymbols(pair.first, for_st->symbol()))
-                    for_st->setDoName(*to);
+                    for_st->setDoName(*pair.second);
         }
 
         for (int i = 0; i < 3; ++i)
@@ -710,12 +710,12 @@ static void renamePrivatesInMap(LoopGraph* loop, const map<SgSymbol*, SgSymbol*>
         for (auto& priv : privates->second)
         {
             bool found = false;
-            for (auto& [from, to] : symbols)
+            for (auto& pair : symbols)
             {
-                if (isEqSymbols(priv, from))
+                if (isEqSymbols(priv, pair.first))
                 {
                     found = true;
-                    newList.insert(to);
+                    newList.insert(pair.second);
                     break;
                 }
             }
@@ -1590,7 +1590,7 @@ static bool combine(LoopGraph* firstLoop, const vector<LoopGraph*>& nextLoops, s
     bool wasCombine = false;
     for (LoopGraph* loop : nextLoops)
     {
-        if (!loop->isFor())
+        if (!loop->isFor)
             return wasCombine;
 
         int perfectLoop = std::min(firstLoop->perfectLoop, loop->perfectLoop);
@@ -1723,7 +1723,7 @@ static bool tryToCombine(vector<LoopGraph*>& loopGraphs, map<LoopGraph*, set<SgS
     {
         LoopGraph* loop = loops[z];
         newloopGraphs.push_back(loop);
-        if (!loop->isFor())
+        if (!loop->isFor)
             continue;
 
         vector<LoopGraph*> nextLoops = getNextLoops(loop, loopGraphs, -1);

src/Transformations/LoopSplitting/loops_splitter.cpp

@@ -1035,7 +1035,7 @@ int splitLoops(SgFile *file, vector<LoopGraph*> &loopGraphs, vector<Messages> &m
 
     for (auto &loopPair : mapLoopGraph)
     {
-        if (!loopPair.second->isFor())
+        if (!loopPair.second->isFor)
             continue;
 
         LoopGraph *loop = loopPair.second;

src/Transformations/PrivateArrayRemoving/private_removing.cpp

@@ -2257,7 +2257,7 @@ void removePrivatesAnalysis(string filename,
 {
     for (LoopGraph* loop : loopGraphs)
     {
-        if (!loop->isFor())
+        if (!loop->isFor)
             continue;
 
         SgForStmt* loopStmt = (SgForStmt*)loop->loop->GetOriginal();

src/Transformations/PrivateArrayResizing/private_arrays_resizing.cpp

@@ -74,7 +74,7 @@ static void fillIterationVariables(const LoopGraph* loop, set<string>& vars, int
 {
     if (dimensions == -1)
     {
-        vars.insert(loop->loopSymbol());
+        vars.insert(loop->loopSymbol);
         for (LoopGraph* child : loop->children)
             fillIterationVariables(child, vars);
     }
@@ -82,7 +82,7 @@ static void fillIterationVariables(const LoopGraph* loop, set<string>& vars, int
     {
         for (int i = 0; i < dimensions; ++i)
         {
-            vars.insert(loop->loopSymbol());
+            vars.insert(loop->loopSymbol);
             if (i != dimensions - 1)
                 loop = loop->children[0];
         }

src/Transformations/ReplaceArraysInIO/replace_dist_arrays_in_io.cpp

@@ -88,36 +88,24 @@ static void populateDistributedIoArrays(map<SgSymbol*, set<SgStatement*>>& array
         case READ_STAT:
         case WRITE_STAT:
         {
-            SgExpression* spec = stat->expr(1);
 
-            if (spec->variant() == SPEC_PAIR)
+            SgExpression* spec = stat->expr(1);
-            {
+            __spf_print(DEBUG_TRACE, "[%d: %s (%d)]\n", 2000, spec->rhs()->unparse(), spec->rhs()->variant());
-                if (spec->rhs()->variant() != KEYWORD_VAL || spec->rhs()->sunparse() != "*")
+            if (!spec || spec->variant() != EXPR_LIST ||
-                {
+                spec->lhs()->variant() != SPEC_PAIR ||
-                    need_replace = true;
+                !spec->rhs() || !spec->rhs()->lhs() || spec->rhs()->lhs()->variant() != SPEC_PAIR)
-                    break;
-                }
-            }
-            else
-            {
-                while (spec)
-                {
-                    auto *kv = spec->lhs();
-                    if (!kv || kv->variant() != SPEC_PAIR || !kv->rhs())
             {
                 printInternalError(convertFileName(__FILE__).c_str(), __LINE__);
                 return;
             }
 
-                    if (kv->rhs()->variant() != KEYWORD_VAL || kv->rhs()->sunparse() != "*")
+            SgExpression* unit_val = spec->lhs()->rhs(), * fmt_val = spec->rhs()->lhs()->rhs();
-                    {
-                        need_replace = true;
-                        break;
-                    }
 
-                    spec = spec->rhs();
+            if (unit_val->variant() != KEYWORD_VAL || unit_val->sunparse() != "*" ||
-                }
+                fmt_val->variant() != KEYWORD_VAL || fmt_val->sunparse() != "*")
-            }
+                need_replace = true;
+
+            break;
         }
         default:
             break;
@@ -148,7 +136,8 @@ static void replaceArrayRec(SgSymbol* arr, SgSymbol* replace_by, SgExpression* e
     if (!exp)
         return;
 
-    if (isArrayRef(exp) && 
+    if (exp->variant() != STMT_STR && exp->symbol() && 
+        exp->symbol()->identifier() && 
         strcmp(exp->symbol()->identifier(), arr->identifier()) == 0)
     {
         has_read |= from_read;
@@ -215,9 +204,11 @@ static void copyArrayBetweenStatements(SgSymbol* replace_symb, SgSymbol* replace
     while (start->lexNext() && !isSgExecutableStatement(start->lexNext()))
         start = start->lexNext();
 
+    auto* stop = last->lexNext();
+
     bool has_read = false, has_write = false;
 
-    for (auto* st = start->lexNext(); st && st != last; st = st->lexNext())
+    for (auto* st = start->lexNext(); st && st != stop->lexPrev(); st = st->lexNext())
         replaceArrayRec(replace_symb, replace_by, st, has_read, has_write);
 
 

src/Utils/PassManager.h

@@ -316,9 +316,7 @@ void InitPassesDependencies(map<passes, vector<passes>> &passDepsIn, set<passes>
 
     list({ VERIFY_INCLUDES, CORRECT_VAR_DECL }) <= Pass(SET_IMPLICIT_NONE);
 
-    list({ CALL_GRAPH, LOOP_GRAPH, CALL_GRAPH2, BUILD_IR }) <= Pass(BUILD_IR_SSA_FORM) <= Pass(FIND_IMPLICIT_LOOPS);
+    list({ CALL_GRAPH2, CALL_GRAPH, BUILD_IR, LOOP_GRAPH, LOOP_ANALYZER_DATA_DIST_S2 }) <= Pass(FIND_PRIVATE_ARRAYS);
-
-    list({ CALL_GRAPH, LOOP_GRAPH, CALL_GRAPH2, BUILD_IR, LOOP_ANALYZER_DATA_DIST_S2 }) <= Pass(FIND_PRIVATE_ARRAYS);
 
     passesIgnoreStateDone.insert({ CREATE_PARALLEL_DIRS, INSERT_PARALLEL_DIRS, INSERT_SHADOW_DIRS, EXTRACT_PARALLEL_DIRS, 
                                    EXTRACT_SHADOW_DIRS, CREATE_REMOTES, UNPARSE_FILE, REMOVE_AND_CALC_SHADOW,

src/Utils/version.h

@@ -1,3 +1,3 @@
 #pragma once
 
-#define VERSION_SPF "2432"
+#define VERSION_SPF "2427"